Deltares / Deltares/imod-python
[FEATURE] - Zone budgets for unstructured data
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
We currently have no convenient way to report zone water balances for DISV (or DISU, for that matter).
With xugrid, it's easy enough to "paint" zones, then do a groupby for boundary conditions, but this isn't the case for face flows.
With face flows, there is one additional intermediate level: you paint the face, but the flow is edge associated (and probably has a sign / direction as well). The best option is likely to defer to xugrid. I've opened https://github.com/Deltares/xugrid/issues/418 to this end.
For xugrid, I'd like to abstract it such that it works for Ugrid1d as well. That would make it useful to e.g. SFR as well.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the requested zone water-balance behavior for DISV and DISU, then review the linked xugrid issue 418. Determine how face-associated, directed flows could be grouped by painted zones and how the abstraction should also support Ugrid1d and SFR; done means the proposed feature covers those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100