Deltares / Deltares/imod-python

Keyword IACTIVE in the iMOD5 PRJ file is not supported

Open
#1,782 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backwards_compatibility documentation
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

Description
A minor bug.
Each package in the PRJ file has the same header: N,TOPIC,IACTIVE. E.g. 0001,(RIV),1, RIVERS
Keyword IACTIVE determines if the package is (de)activated for the simulation.
in the current release, IACTIVE = 0 is not supported.

Important practical use of this keyword is to speed up the preprocessing from a PRJ file. For instance leaving out the RIV or WEL package in case a package contains extended time series.

Suggestion for Issue handling
The fix should probably be made in function imod.formats.prj.open_projectfile_data.
It is not a killing bug, alternative is to remove the particular package by hand from the dictionary returned by the same function imod.formats.prj.open_projectfile_data.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in imod.formats.prj.open_projectfile_data, which the issue identifies as the likely fix location, and inspect how the IACTIVE value is handled while parsing PRJ package headers. Done means PRJ packages with IACTIVE = 0 are correctly excluded or deactivated while active packages continue to work; verify the parser behavior with representative PRJ input.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.