Deltares / Deltares/imod-python

[FEATURE] - Modflow6Simulation.clip_box should be able to adapt InitialConditions too.

Open
#1,740 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clipping Deltares enhancement
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

@jdelsman mentioned that Modflow6Simulation.clip_box can change InitialConditions if time_min and states_for_boundary are provided. This is especially useful for transport models, which act on larger timescales.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Modflow6Simulation.clip_box entry point and trace how time_min and states_for_boundary are currently handled. Determine how InitialConditions are represented and affected by clipping, especially for transport models. Done means clip_box adapts InitialConditions when those arguments are provided; the issue names no files or tests, so the relevant coverage still needs to be located.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.