Deltares / Deltares/imod-python
[Bug] - Well.clip_box doesn't work with dask arrays
Open
Nobody has claimed this yet.
bug
clipping
Deltares
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
Bug description
Got a report from @jdelsman :
He ran into this issue when opening a previously dumped model (which opens data as Dask arrays), then consequently trying to call clip_box it.
Steps to reproduce
- What error message do you get?
NotImplementedError: The out parameter is not fully supported. Received type ndarray, expected Dask Array
sim = imod.mf6.Modflow6Simulation.from_file(fn_orgmodel_toml)
sim_clipped = sim.clip_box(xmin = xmin, xmax = xmax, ymin = ymin, ymax = ymax)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with Modflow6Simulation.from_file and then calling clip_box on the loaded simulation, as shown in the report. Trace the clip_box path and verify that clipping a simulation backed by Dask arrays completes without the reported NotImplementedError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100