Deltares / Deltares/imod-python

[FEATURE] - imod.mf6.open_hds and imod.mf6.open_cbc should be able to merge split domains as well

Open
#1,728 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Deltares enhancement
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

Is your feature request related to a problem? Please describe.
Mentioned by @jdelsman :

Right now only imod.mf6.Modflow6Simulation.open_hds and imod.mf6.Modflow6Simulation.open_cbc support merging output together. This is nice for tutorials, but often these large simulations are ran outside the python process, and reading output is done in a separate script. For this, we do not want to construct imod.mf6.Modflow6Simulation objects again.

So it is a necessity to have the functions imod.mf6.open_hds and imod.mf6.open_cbc to be able to merge those outputs as well. Or create separate functions to open output and merge.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing imod.mf6.open_hds and imod.mf6.open_cbc with Modflow6Simulation.open_hds and Modflow6Simulation.open_cbc, focusing on how the simulation methods merge split-domain outputs. Verify the standalone functions can provide equivalent merging without constructing a simulation object, and confirm this behavior with tests for split domains.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.