Deltares / Deltares/imod-python
Modflow6Simulation.split assumes unique names between transport and flow models
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
The split method contains this line:
original_models = {**flow_models, **transport_models}
This'll only work if there are no duplicate names? In most cases this'll be the case, or the name conflict won't have effect (e.g. on the DIS package), but if I give my GHB and DSP packages the same name, we won't be happy with the result!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Modflow6Simulation.split and the construction of flow_models and transport_models; reproduce the case where GHB and DSP packages share a name. Done means the split behavior is defined and covered for duplicate names, without changing the handling of non-conflicting models.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100