Deltares / Deltares/imod-python
MetaSWAP Sprinkling class can't deal with Nan's in 'irrigation layer' grid
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
This is the case when generating a model based on iMOD5 PRJ-file. If the 'irrigation layer' grid contains Nan's in the inactive area, an unclear index error occur when rendering the output file. This is due to the internal conversion to integers.
1- We should have a better input check on this, and raise a clear error message
2- We could use a fill value before the integer conversion. But this needs to be a valid layer number since it is also used as an index, when finding the active cell's.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the MetaSWAP Sprinkling class when it renders the output file for models generated from an iMOD5 PRJ-file, focusing on the irrigation layer grid and its internal integer conversion. Determine how NaN values in inactive areas are handled, then verify that the resulting input check or fill-value behavior produces a clear error or valid output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100