Deltares / Deltares/imod-python
[FEATURE] - Let type dispatching also support Ugrid2d objects
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
In https://github.com/Deltares/imod-python/pull/1579, I ran into the problem where type dispatching resulted didn't accept Ugrid2D objects, so I therfore had to create a dummy UgridDataArray to regrid a simulation. Not the end of the world, but a bit clunky to say the least.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pull request 1579 and tracing the type-dispatching path involved in regridding. Done means Ugrid2d objects are accepted directly for simulation regridding, without requiring a dummy UgridDataArray; add or update coverage for that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100