Deltares / Deltares/imod-python

array io save fails on non-sorted extra dims

Open
#154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @Huite on Feb 7, 2021, 19:42

Calling e.g. imod.idf.save results in an error if a time dimension isn't sorted.

The resulting error (mentioning "idf", which is the "extra dim"), is confusing.

Could either be a thing with the stack function, or add a better error message.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure through im​​od.idf.save with an unsorted time dimension, then inspect the stack function involved in handling extra dimensions. Determine whether the save path should handle the ordering or produce a clearer error mentioning the actual problem; done means the failure is resolved or the resulting message is no longer confusing.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.