Deltares / Deltares/imod-python
Validate linear_acceleration entry in solver settings
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
There are a number of settings in MODFLOW 6 which will result in an asymetric coefficient matrix.
Newton is true
hhformulation_rhs = false
Maybe XT3D = true?
I think for the solute transport there are other conditions. It would probably be good to validate the linear_acceleration value which defaults to cg on this.
There is also a case to be made that if the coefficient matrix is symmetric, cg is almost always the better choice. That's not a good validation option though, maybe a warning (though that's annoying too...).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the solver settings handling for linear_acceleration and its default of cg. Review how Newton, hhformulation_rhs, XT3D, and solute-transport conditions affect matrix symmetry. Done means validating incompatible settings, with the applicable conditions established and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100