Deltares / Deltares/imod-python

Expand model fixtures to also test methods for repeat_stress

Open
#1,307 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs tests
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

Currently not all our model methods are not tested with a model fixture that contains repeat_stresses, this can result in bugs like clip_box not working for these models

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the model fixtures and the methods currently covered by them, then identify which fixtures include repeat_stresses. Extend the test coverage so the relevant model methods are exercised with that fixture, and consider the work done when those methods are covered without repeat_stresses-related failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.