Deltares / Deltares/imod-python

Quality-of-life: automatically add top and bottom as coordinate to MF6 output

Open
#1,240 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

After discussion with @FransRoelofsen: making e.g. a streamfunction plot or a cross-section plot requires manually adding top and bottom coordinates to the DataArray -- this while we provide the GRB file during reading to infer the grid topology.

It seems like a minor effort to add top and bottom data by default: it's been read from the GRB file anyway, and we require the GRB file to read budget and head results.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the MF6 budget and head result reading that already uses the GRB file, and identify where grid topology reaches the DataArray. Confirm how top and bottom coordinates are currently added for streamfunction or cross-section plots; done means those coordinates are present by default without manual additions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.