Deltares / Deltares/imod-python
Modflow 6 well edge case when located on partition border
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
When Well's are located on the edge of a partition border, wells are located to both partitions for unstructured grids, and since https://github.com/Deltares/imod-python/pull/1189 also for stuctured grids.
After a discussion with @Huite, I concluded that the easiest way forward is probably to add a post-processing step to Modflow6Simulation.split, which looks for duplicate well entries (maybe by index or 'id' if possible) amongst different model partitions and select one.
Note: Wells are still grid agnostic after splitting, assigning wells to cells occurs in the call to Modflow6Simulation.write().
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Modflow6Simulation.split and inspect how well entries are distributed across model partitions; Modflow6Simulation.write is where wells are later assigned to cells. Trace how duplicate wells can be identified across partitions, then verify that each border well is retained only once while remaining grid agnostic until write.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100