Deltares / Deltares/imod-python

imod.visualize.cross_section should work automatically for voxel models

Open
#113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

In GitLab by @muldernielsdeltares on Jan 16, 2020, 13:15

The first argument da currently requires both top and bottom coordinates to be set. These can be inferred if z is available for a voxel type model.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the imod.visualize.cross_section entry point and inspect how the da argument currently obtains top and bottom coordinates. The change is complete when voxel models with z available infer both coordinates automatically, while models or calls with explicit coordinates continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.