Deltares / Deltares/imod-python

create an imod5 import context

Open
#1,099 1 comment 0 reactions 1 assignee View on GitHub

@luitjansl is already working on this.

Since Jul 18, 2024.

Dominant language
Python
Stars
41
Forks
12
Avg merge
21h 8m
Merged PRs (30d)
1

Description

This will allow us to pass data used for importing objects , such as:

  • regridder settings/ regridder context
  • the desired time discretization
  • any other information needed for importing
  • River/Drain/GHB allocation and conductance distribution methods

The context should be an object containing this data and it should be an argument for the from_imod5_data methods.

It can be a bit daunting to users to make these custom objects so:

Requirements

  • Docstring with examples how to make these for API docs
  • Update tutorial/examples in documentation
  • Some form of input validation to help them out if things fail. Pydantic would be an interesting option for this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.