Deltares / Deltares/imod-python
SolutionPresets should still require outer_dvclose, inner_dvclose, and inner_rclose; and evaluate arguments more broadly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 12
- Avg merge
- 21h 8m
- Merged PRs (30d)
- 1
Description
The current presets follow what was written in the MODFLOW 6 documentation. The reason we duplicate these settings is for discoverability, so they are explicitly printed in the IMS file.
However, the outer_dvclose for e.g. the complex preset is 0.1, which is unusably big for almost all our applications. We should always require the users to provide these settings themselves for Simple, Medium, and Complex presets.
It's also worth considering which other arguments should be included exactly. They can always be set via mutations afterwards too.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the SolutionPresets implementation and the handling of preset arguments. Compare the Simple, Medium, and Complex presets, then verify that outer_dvclose, inner_dvclose, and inner_rclose are required and explicitly printed in the IMS output. Also review which additional arguments are evaluated consistently before deciding whether they belong in scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100