DefinitelyTyped / DefinitelyTyped/DefinitelyTyped
[fabric] Do not overwrite native `Object` type
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 51.4k
- Forks
- 30.4k
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 108
Description
Fabric type definition overwrites native Object constructor, which makes Typescript autocomplete to suggest all properties defined in Fabric's Object type when destructuring (See the screenshot)
Removing this line in my local environment makes the IDE not to suggest incorrect properties anymore - that's because the global Object constructor doesn't get merged with the one from Fabric's implementation.
Can you please remove this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open types/fabric/fabric-impl.d.ts at line 3189 and inspect the Fabric declaration that overwrites the native Object constructor. Remove that declaration, then verify that TypeScript autocomplete no longer suggests Fabric Object properties when destructuring and that the definition remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100