DefinitelyTyped / DefinitelyTyped/DefinitelyTyped
[@types/webpack-env] Interface 'NodeJS.Module' incorrectly extends interface '__WebpackModuleApi.Module'
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 51.4k
- Forks
- 30.4k
- Avg merge
- 3d 21h
- Merged PRs (30d)
- 108
Description
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch @types/webpack-env@1.16.0 for the project I'm working on.
This is a proposed fix for https://github.com/DefinitelyTyped/DefinitelyTyped/issues/45993
Here is the diff that solved my problem:
diff --git a/node_modules/@types/webpack-env/index.d.ts b/node_modules/@types/webpack-env/index.d.ts
index 195a17a..a1f9ae2 100644
--- a/node_modules/@types/webpack-env/index.d.ts
+++ b/node_modules/@types/webpack-env/index.d.ts
@@ -70,7 +70,7 @@ declare namespace __WebpackModuleApi {
loaded: boolean;
parent: NodeModule | null | undefined;
children: NodeModule[];
- hot?: Hot;
+ hot: Hot;
}
type ModuleId = string|number;
This issue body was partially generated by patch-package.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in node_modules/@types/webpack-env/index.d.ts around __WebpackModuleApi.Module and compare the hot property with NodeJS.Module. Apply the proposed declaration change, then verify that the original TypeScript incompatibility is resolved; no test file is mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100