DefinitelyTyped / DefinitelyTyped/DefinitelyTyped

activedirectory2, Promise wrapper seems missing from types

Open
#42,295 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
51.4k
Forks
30.4k
Avg merge
3d 21h
Merged PRs (30d)
108

Description

I saw on the project NPM page that a Promise wrapper is available but I think it's missing from the types.

const AD = require('activedirectory2').promiseWrapper;

I honestly don't know how to add this additional interface and how to export it but I think it won't be much trouble as the API is probably very similar to the callback one.

Authors: @PAStheLoD

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the activedirectory2 type definition and the require('activedirectory2').promiseWrapper entry point shown in the report. Compare the callback API's existing typings, then verify that promiseWrapper is exported and its public methods are typed; the issue provides no test file to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
developer-experience
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.