DefinitelyTyped / DefinitelyTyped/DefinitelyTyped

@types/koa: new http2/node 9 dependency is a breaking change without major version number update

Open
#24,863 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
51.4k
Forks
30.4k
Avg merge
3d 21h
Merged PRs (30d)
108

Description

  • [ x] I tried using the @types/koa package and had problems.
  • [x ] I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript
  • I have a question that is inappropriate for StackOverflow. (Please ask any appropriate questions there).
  • [ x] Mention the authors (see Definitions by: in index.d.ts) so they can respond.
    • Authors: @DavidCai1993 @jkeylu @brikou

The dependencies for @types/koa 2.0.45 have changed in a breaking way from version 2.0.44 (it now must be compiled using node 9) but there's been no change to the major version number. This violates semver and breaks people's builds. I'm not making a PR because this seems like an administrative issue rather than technical. Am I missing something?

I'm also seeing this error, which I guess to be related: node_modules/@types/koa/index.d.ts(104,14): error TS2694: Namespace '"url"' has no exported member 'URL'.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the @types/koa 2.0.44 and 2.0.45 dependency metadata and reviewing node_modules/@types/koa/index.d.ts around line 104. Reproduce the reported URL type error with the stated TypeScript setup, then determine the appropriate compatibility or versioning change and verify that the affected build succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.