DefGuard / DefGuard/defguard

Align OIDC and mobile-approve on a single out-of-band mechanism

Open
#3,586 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.8k
Forks
115
Avg merge
1d 4h
Merged PRs (30d)
51

Description

The two out-of-band MFA methods use different mechanisms: OIDC is poll-only, mobile-approve is WS-primary with poll fallback.

This is deliberate, not accidental. OIDC's callback arrives as an HTTP redirect into enterprise/grpc/desktop_client_mfa.rs, so there is no oneshot to park - park is inapplicable, not merely unpreferred. Mobile-approve already has an open WebSocket, so parking is the natural fast path.

Converging them would simplify the engine and the #3046 contract.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.