Decathlon / Decathlon/ara

Handle loading spinner on API calls

Open
#290 0 comments 0 reactions 0 assignees View on GitHub
Technical Enhancement
Dominant language
Java
Stars
80
Forks
17
PR merge metrics
No merged PRs in 30d

Description

**What it's the actual situation on ARA ?**
The loading spinner is manually managed by using a (boolean) variable to show/hide it depending on its current state (e.g. waiting for the API call to finish, errors, etc.). Although this works, there are a few disadvantages:
- This is extra work
- It can be error prone (e.g. forgetting to end the spinner)
- You can forget to add it
- It is not a good practice

**Describe the solution you'd like**
An interceptor is a good solution.

> **IMPORTANT**: Don't forget to delete all the "manual" spinners

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the API-call paths that manually toggle the loading spinner and identify the request entry point where interceptor-based handling belongs. Done means spinner handling is centralized and all manual spinner management is removed; verify the affected API-call flows, including errors.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.