DeFiCh / DeFiCh/ain

walletimport: doesn't understand erc55 addresses in the dump format

Open
#2,972 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
397
Forks
129
PR merge metrics
No merged PRs in 30d

Description

## Summary

- `walletimport` doesn't understand 0x addresses in the dump and as such the import fails.
- `walletdump` after generation of addresses (`getnewaddress`) beyond the original key pool will also generate ERC55.

### To reproduce

- Create a new wallet.
- Generate a few addresses with `getnewaddress`
- `dumpwallet`
- Attempt to reimport it again with `importwallet`

### Temporary workaround

- Using a regex replace to remove the erc55 addresses should make the dump file important again.
- Eg: `sed "s/\(addr=\w\+\),0x\w\+/\1/g" wallet.dump > wallet.importable.dump` to generate a new importable file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.