DavidWells / DavidWells/markdown-magic
Correctly replace the node_modules folder in the ignore list
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 868
- Forks
- 223
- PR merge metrics
- No merged PRs in 30d
Description
This line is preventing me to exclude the common/temp/node_modules directory of my monorepo and any "subproject" node_modules directory 😢
e.g. If I md-magic --path '**/*.md' --ignore 'common/temp/node_modules/**', the tool tries to modify its own examples because it finds it in the common/temp/node_modules directory (which is the global store for every dependency of the monorepo).
Is it possible to replace it with something more robust? Maybe just use !**/node_modules/** (⚠️ if it works)?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read cli.js at line 47 and trace how the ignore pattern is combined with --path. Reproduce the issue with the provided md-magic command and a nested common/temp/node_modules directory; done means the explicit ignore excludes that directory and nested node_modules locations without modifying the examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100