DavidWells / DavidWells/markdown-magic
Time to drop `sync-request`?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 868
- Forks
- 223
- PR merge metrics
- No merged PRs in 30d
Description
Is it time to drop sync-request from this project?
Recently github notified me about a vulnerability introduced by markdown-magic through sync-request (which has not been updated in 6 years), that ultimately came from an ancient form-data 2. 5 version. It was nothing to worry about because, as far as I know, markdown-magic doesn't even use sync-request. The only file making a reference is packages/core/src/utils/remoteRequest.js but remoteRequestSync does not seem to be used anywhere.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/core/src/utils/remoteRequest.js and inspect the remoteRequestSync reference mentioned in the issue, then search the project for other sync-request usage. Confirm whether the synchronous path is unused and whether the dependency can be removed; done means no unnecessary sync-request reference or dependency remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100