DavidWells / DavidWells/analytics
Broken `analytics-node` initialization in `analytics-plugin-segment`
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.7k
- Forks
- 267
- PR merge metrics
- No merged PRs in 30d
Description
Hello @DavidWells ,
First of all, thank you for your effort in creating such a library 💪
Looks like analytics-plugin-segment is broken for nodejs as it use wrong initialization for analytics-node
at https://github.com/DavidWells/analytics/blob/master/packages/analytics-plugin-segment/src/node.js#L48
By the way analytics-node is deprecated so we could switch to maintained one @segment/analytics-node
https://segment.com/docs/connections/sources/catalog/libraries/server/node/migration/
PS
Feel free to ping me if you would like me to create PR with such changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at packages/analytics-plugin-segment/src/node.js around line 48 and compare its analytics-node initialization with the linked Segment migration guidance. Check the package's Node entry point and dependency configuration; done means the Segment plugin initializes correctly for Node using the maintained library, with the existing Node behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100