DavidWells / DavidWells/analytics
Google Tag Manager page implementation doesn't seem right
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.7k
- Forks
- 267
- PR merge metrics
- No merged PRs in 30d
Description
The page implementation in google tag manager just sends the page properties into dataLayer without adding an event key or anything that would make this usable as a GTM trigger.
I think it could possible add an event key like page_view or maybe just not implement page at all as I don't think there's a standard format for sending page views - GTM just generates its own page view on load and doesn't provide any way to send fake page views that it would treat as a "Page View".
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Google Tag Manager page implementation and inspect how it writes page properties into dataLayer. Compare that behavior with the repository's GTM event handling, then confirm whether the intended resolution is adding a usable event key or removing the unsupported page implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- analytics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100