DavidWells / DavidWells/analytics
The code will throw the error "cannot read [0] of undefined", if endpoint.Attributes.lastPageSession is undefined
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.7k
- Forks
- 267
- PR merge metrics
- No merged PRs in 30d
Description
Seems we need to confirm endpoint.Attributes.lastPageSession is not undefined before getting the first item.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/analytics-plugin-aws-pinpoint/src/pinpoint/helpers/merge-endpoint-data.js at the linked line and trace how endpoint.Attributes.lastPageSession is accessed. Add coverage for an endpoint where that attribute is undefined, then run the relevant package tests and confirm the merge no longer throws.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, javascript
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100