Datatamer / Datatamer/tamr-client

TC: attribute.create does not have a "force" parameter

Open
#352 0 comments 0 reactions 0 assignees View on GitHub
🐛 Bug 📝 Docs good first issue
Dominant language
Python
Stars
11
Forks
24
PR merge metrics
No merged PRs in 30d

Description

# 🐛 bug report

Docstring for `tc.attribute.create` includes a [`force` parameter](https://github.com/Datatamer/tamr-client/blob/master/tamr_client/attributes/attribute.py#L190), but the function does not have such a parameter.

## 🤔 Expected Behavior

Docstring should not contain `force` param.

## 😯 Current Behavior

Docstring contains `force` param.

## 💁 Possible Solution

Remove `force` param from `tc.attribute.create` docstring

## 🔦 Context

Originally, the `force` parameter was used to skip reserved attribute name checking, but since we have `tc.attribute._create` (note the leading `_`) for that exact purpose, we no longer needed the `force` parameter. That parameter was removed, but the docstring erroneously kept it.

## 💻 Code Sample

N/A

## 🌍 Your Environment

`tamr_client`

| Software | Version(s) |
| ----------------- | ---------- |
| tamr-unify-client | 0.11.0-dev
| Tamr server | n/a
| Python | 3.6.5
| Operating System | MacOS

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.