AddressSearch, Pins, ReverseGeocoder: Reference hell
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 50
- Forks
- 8
- Avg merge
- 18h 24m
- Merged PRs (30d)
- 11
Description
Describe the bug
The selected result of a successful search may be updated without the intent of the user.
This happens in a typical configuration that can be e.g. found in snowbox.
There, a selected search result sets a pin, which triggers a reverse geocoding. The result of that gets added to the addressSearch input.
This leads to two problems:
- The user sometimes sees the loader for extended periods of time due to the unwanted reverse geocoding
- The changed result may confuse users
Expected behavior
The selected result may only be updated if the user selects a result or sets a pin themselves.
Steps to reproduce
- Start
snowbox - Search for "Billstraße"
- Select "Billstraße"
- The result gets updated to "Billstraße 144"
Additional context
This problem also occurrs on main as far as I can tell and thus should be fixed on both branches.
It is also possible that other plugins may have such cyclic references. It may be reasonable to tackle this issue in a generalized scoped.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the flow in snowbox: search for “Billstraße,” select it, and observe the interaction between AddressSearch, Pins, and ReverseGeocoder. Trace how reverse-geocoding updates the selected result and identify whether the same cycle can occur through other plugins. Done means only explicit user selection or pin placement updates the result, without the unwanted loader, on both branches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100