DataTalksClub / DataTalksClub/website
Restore green CI on main: ruff B905 (zip strict=) from 6db5c2b3 blocks the quality job
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Observed by on-call after the #382 merge push (d7e53f5f, CI run 35010874544) and confirmed pre-existing.
Evidence
- Job
qualityfails: ruffB905 zip()without explicitstrict=atcourses/tests/test_course_illustrations.py:127. Reproduced locally atd7e53f5fwith the exact CI command. Introduced by6db5c2b3(pushed 18:11Z); quality passed at the prior head55a400c7(15:56Z). - Because the quality contract aborts on first failure, django/playwright were cancelled at
b297191dandd7e53f5f. Deploy Dev verify-ci failed, deploy skipped. - Independent pre-existing red: at
55a400c7(quality green), django failed withfailures=16, errors=1and playwright failed (accessibility/article-parity among them). Attribution of those to introducing commits is still open; do not treat them as acceptable.
Acceptance criteria
-
B905fixed (strict=True; the zipped literals are equal-length) and the full quality contract passes locally, not just to the first failure - typecheck and format-check targets re-run clean (separate
assert is not Nonenarrowing and reflow fixes are in flight in the shared checkout) - push to
mainre-observed: quality, django, playwright jobs all green or each remaining failure attributed to an owning issue - Deploy Dev goes green at the fixed head
Fix is in progress in the shared main checkout (uncommitted at time of filing); commit with Refs #N pointing at this issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at courses/tests/test_course_illustrations.py:127 and verify the B905 failure against the quality contract. Confirm the full quality, typecheck, and format-check targets pass, then re-run django, playwright, and Deploy Dev at the fixed main head; remaining failures should be attributed to an owning issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ci-cd, devops, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100