DataTables / DataTables/Select
When serverSide is on not all selected items are being selected
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 44
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Description
Hi.
I believe I stumbled on a bug.
The preXhr listener preXhr.dt
attempts to give a solution to keeping the selected items in place when serverSide is on.
The code misses to account for more than two consecutive xhr requests since the whole list of
selected items is not kept but rather only the list of selected in the current page.
Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in js/dataTables.select.js at the preXhr.dt listener around line 606, then reproduce the behavior with serverSide enabled across more than two consecutive XHR requests. Done means the complete selected-item list is preserved so previously selected items remain selected after subsequent requests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100