DataTables / DataTables/SearchBuilder
SearchPanes integration examples throw javascript errors
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 23
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
The two SearchPanes integration examples fail to load in Microsoft Edge and Mozilla Firefox with a "DataTables warning: table id=example - Unknown feature: searchPanes".
Affected:
- https://datatables.net/extensions/searchbuilder/examples/integration/searchPanes.html
- https://datatables.net/extensions/searchbuilder/examples/integration/searchPanesCascadeViewTotal.html
Source files:
examples/integration/searchPanes.xmlexamples/integration/searchPanesCascadeViewTotal.xml
I was unable to verify the fix so I will not be submitting a PR but I believe the following diff fixes both pages. I built all of DataTablesSrc and SearchBuilder and ran the web server (i.e. npm run serve) and could not figure out how to get the top and left navbars to show to confirm the fix.
diff --git a/examples/integration/searchPanes.xml b/examples/integration/searchPanes.xml
index 17367f6..2848f42 100644
--- a/examples/integration/searchPanes.xml
+++ b/examples/integration/searchPanes.xml
@@ -3,6 +3,7 @@
<css lib="datatables searchbuilder searchpanes select datetime"/>
+<js lib="jquery"/>
<js lib="datatables searchbuilder searchpanes select datetime">
<![CDATA[
diff --git a/examples/integration/searchPanesCascadeViewTotal.xml b/examples/integration/searchPanesCascadeViewTotal.xml
index f795afc..2e0657f 100644
--- a/examples/integration/searchPanesCascadeViewTotal.xml
+++ b/examples/integration/searchPanesCascadeViewTotal.xml
@@ -3,6 +3,7 @@
<css lib="datatables searchbuilder searchpanes select datetime"/>
+<js lib="jquery"/>
<js lib="datatables searchbuilder searchpanes select datetime">
<![CDATA[
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with examples/integration/searchPanes.xml and examples/integration/searchPanesCascadeViewTotal.xml, then inspect how their JavaScript libraries are loaded. Run npm run serve and open both affected integration examples in Edge or Firefox. Done means both pages load without the unknown feature: searchPanes warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, jquery
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100