DataTables / DataTables/SearchBuilder
SearchBuilder + SSP + ColReorder fires unnecessary XHR
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 23
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
The combination of these three gives the functionality that a colReorder sends off an XHR request that I think is unnecessary - even when there are no criteria in SearchBuilder. Turning off SB prevents this request.
https://live.datatables.net/vazuwuza/9/edit
This is not an issue with small datasets but makes colReorder unusable with large ones, mostly because the XHR event is fired instantly when the column is in a new place. An indirect fix could be to make the event fire only on mouse up?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked live.datatables.net example and reproduce the interaction between SearchBuilder, SSP, and ColReorder while watching the XHR requests. Done means moving a column with no SearchBuilder criteria no longer triggers an unnecessary immediate request, while required requests still occur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100