DataTables / DataTables/Plugins

full_numbers_no_ellipses not working in v2

Open
#586 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

I have found that the plugin does not get the parameters (page,pages).
My fix is to get these from the table itself.
I removed the parameters and added this.

var pageinfo = table.page.info();
var page = pageinfo.page;
var pages = pageinfo.pages;

Everything now works as expected.
It looks like this will apply to all the pagination plugins.

HTH
Brian

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the full_numbers_no_ellipses pagination plugin and inspect how it receives the page and pages parameters. Compare it with the table.page.info() values described in the issue, then check the other pagination plugins for the same pattern. Done means pagination works in v2 without externally supplied page and pages values.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.