DataTables / DataTables/Plugins

Internationalisation plug-in Contribution Editor Has Incorrect Keys

Open
#537 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

As seen in the attached screenshot, the editor has the keys "searchBuilder.conditions.string.notStarts" and "searchBuilder.conditions.string.notEnds", but the correct keys end with "notStartsWith" and "notEndsWith".

Furthermore, all of the "condition.string" keys should be grouped together.

Screen Shot 2022-02-24 at 4 00 14 AM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the internationalisation plug-in Contribution Editor and compare its condition.string keys with the linked SearchBuilder criteria.ts reference. Correct notStarts and notEnds to the With forms, group all condition.string keys together, and verify the editor output matches the reference.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.