DataTables / DataTables/Plugins
dom-checkbox plugin conflicts with datetime-moment
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
If you have the datetime-moment plugin loaded and add a moment type the dom-checkbox plugin (and maybe others) will not work properly anymore.
This is caused by the dom-monent plugin also accepting empty strings (or strings only consisting of HTML tags) as valid dates and therefor assigning a moment date type to the column. The custom data from the dom-checkbox plugin can then not be sorted anymore, because it is not a valid date format.
I see two possible fixes:
- don't detect empty strings as dates
- do the format detection on the output of the custom data source plugin.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the dom-checkbox, datetime-moment, and dom-moment plugin implementations and reproduce the conflict with empty or HTML-only values and custom checkbox data. Check how date types are detected and sorting is selected; done means the custom data remains sortable when datetime-moment and dom-checkbox are loaded together.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100