DataTables / DataTables/Plugins
SearchHighlight doesn't work correctly IE8
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
i don't know IE8 support is given
if you Filter more than 1 char and going backwards a copy of the td-element is insert into the td
before a filter is set
<TD class="dt-body-left">Aval</TD>
apply filters to A
<TD class="dt-body-left"><SPAN class=highlight>A</SPAN>v<SPAN class=highlight>a</SPAN>l</TD>
apply filters to A
<TD class="dt-body-left"><SPAN class=highlight>A</SPAN>v<SPAN class=highlight>a</SPAN>l</TD>
apply filters to Av
<TD class="dt-body-left"><TD class="dt-body-left"></TD><SPAN class=highlight>Av</SPAN>al</TD>
i don't know why, but it seems to be a problem with parent.normalize in function unhighlight (jquery.highlight.js)
the error also occurs on datatables - Search result highlighting
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with jquery.highlight.js, especially the unhighlight function and its use of parent.normalize. Reproduce the issue in IE8 by applying filters to “A” and then “Av”, including the linked DataTables search-highlighting example. Done means filtering backward no longer inserts a duplicate TD element.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100