DataTables / DataTables/Plugins

bootstrap plugin with RTL pages

Open
#177 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

There are various problems with right-to-left pages (arabic, hebrew, etc.), all caused by explicit left / right attributes in the CSS. For example,

  1. alignment/margins of the elements in the thead and tfoot
  2. left-hand column has no right-hand border
  3. sort icons at wrong end of label

A common fix for these problems is to add an RTL override for each rule that contains a left or right attribute. e.g.

.foo {
  text-align: left;
  margin-right: 10px;
}

[dir=rtl] .foo {
  text-align: right;
  margin-right: inherit;
  margin-left: 10px;
}

Of course, the majority of sites are LTR only, and no doubt people will complain of unncessary bloat.

Are you interested in RTL issues? I want to check before I spend time creating a PR.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no file or test; start by locating the Bootstrap plugin CSS rules that use explicit left or right properties and reproduce the listed RTL problems for thead, tfoot, borders, and sort icons. Done would require an agreed RTL scope and verified fixes for those cases without unacceptable stylesheet bloat.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, css, javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.