DataTables / DataTables/NET

MJoin Model does not support nested types.

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
19
Forks
11
PR merge metrics
No merged PRs in 30d

Description

https://github.com/DataTables/Editor-NET/blob/master/DataTables-Editor-Server/MJoin.cs#L750

VS

https://github.com/DataTables/Editor-NET/blob/master/DataTables-Editor-Server/Editor.cs#L1394

Issue:

https://datatables.net/forums/discussion/78941/editor-net-mjoin-leftjoin-data#latest

This forces us to define the nested fields manually via:

.MJoin(new MJoin("InventoryServerWarranty")
    .Model<InventoryServerWarranty>()
    .Field(new Field("InventoryServerWarrantyProvider.Name"))
    .Field(new Field("InventoryServerWarrantyProvider.Description"))

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing DataTables-Editor-Server/MJoin.cs around line 750 with Editor.cs around line 1394, then read the linked forum discussion for the nested-type and left-join context. The change is complete when MJoin.Model() supports the nested fields described in the issue without requiring each field to be defined manually.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.