DataTables / DataTables/FixedHeader

Allow to configure fixed element container

Open
#89 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
73
Forks
83
Avg merge
4m
Merged PRs (30d)
1

Description

We've got still some issues with form and FixedHeader/Footer (#68). Wouldn't it be sufficient to make the container configurable? At the moment the floating footer get's appended to body. If we'd move it out of the table into the surrounding form it'll still work out-of-the-box:

Before DT triggers:

<body>
    <form>
        <table>
            <tbody><!-- some rows --></tbody>
            <tfoot><!-- some actions --></tfoot>
        </table>
    </form>
</body>

Current version:

<body>
    <form>
        <table>
            <tbody><!-- some rows --></tbody>
        </table>
    </form>
    <table>
        <tfoot><!-- some actions --></tfoot>
    </table>
</body>

Alternate solution:

<body>
    <form>
        <table>
            <tbody><!-- some rows --></tbody>
        </table>
        <table>
            <tfoot><!-- some actions --></tfoot>
        </table>
    </form>
</body>

https://github.com/DataTables/FixedHeader/blob/master/js/dataTables.fixedHeader.js#L285

Cheers
Matthias

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in js/dataTables.fixedHeader.js around line 285, where the issue identifies the floating footer being appended to body. Trace that placement logic and verify the requested configurable-container behavior against the form-contained markup shown in the issue, while preserving the existing default behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.