DapperLib / DapperLib/DapperAOT
Query text passed over string variable is not picked up by Analyzer
Open
Nobody has claimed this yet.
analyzer
- Dominant language
- C#
- Stars
- 472
- Forks
- 43
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 18
Description
Example:
public async Task<List<Symbol>> GetAllSymbolsVariable()
{
var sql = "select * from Symbol";
var results = await Conn().QueryAsync<Symbol>(sql); // no warning
return results.AsList();
}
public async Task<List<Symbol>> GetAllSymbolsInline()
{
var results = await Conn().QueryAsync<Symbol>("select * from Symbol"); // has warning
return results.AsList();
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the two QueryAsync examples from the issue and compare the analyzer behavior for the inline query and the sql variable. Start at the analyzer handling of QueryAsync calls; done means the variable form receives the same warning as the inline form without changing the existing inline behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100