DapperLib / DapperLib/DapperAOT
Missing brackets from IN clause causes Error - code still works
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 472
- Forks
- 43
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 18
Description
SQL string looks something like "... WHERE [DividendId] IN @Ids ORDER BY [SecId];"
This caused error DAP206 Incorrect syntax near @Ids, but the code executes as expected without having the brackets around the IN parameter,
Should this be an Error or a Warning - if the code still works, it feels like a Warning, and the correction an advisory.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DAP206 diagnostic implementation and any tests covering the missing brackets around an IN parameter. Reproduce the shown SQL case and compare the diagnostic behavior with the fact that execution succeeds. Done means the issue's requested Error-versus-Warning behavior is resolved and covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, sql
- Domain
- databases, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100