DapperLib / DapperLib/Dapper

SimpleMemberMap became internal between 1.42 and 1.50.2

Open
#613 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

area:api breaking-change v3.0
Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

We've just updated our NuGet package from 1.42 to 1.50.2, and at some point in between those two, SimpleMemberMap has become internal (a breaking change). I can't spot anything on the release notes mentioning this. Please can someone suggest how to create one of these, or what the new way of creating a SqlMapper.IMemberMap is? We were using it like this...

_customMappedMembers[nameToMap] = new SimpleMemberMap(nameToMap, _type.GetProperty(member.Name));

and

 _customMappedMembers[nameToMap] = new SimpleMemberMap(nameToMap, _type.GetField(member.Name));

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the public API around SimpleMemberMap and SqlMapper.IMemberMap, then compare the 1.42 and 1.50.2 package behavior. Determine the supported way to create an IMemberMap and verify whether the breaking change should be documented in the release notes; done means the replacement or compatibility guidance is clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.