DapperLib / DapperLib/Dapper

No QueryAsync overload which accepts CommandDefinition, for cancellation, and Type array, for unbounded map

Open
#2,193 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

As per the title, there's no QueryAsync overload which accepts a CommandDefinition and a Type[] + Func<object[], TReturn> mapper, which means if you have > 7 types you want to map out of your query, and you want the query to be cancellable, you're out of luck. Not sure if this is intentional, but I do see the private method MultiMapAsync<TReturn>, which is called into by many of the existing overloads, does appear to support this variation. Any guidance on how to resolve would be greatly appreciated, thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing public QueryAsync overloads with the private MultiMapAsync method mentioned in the issue. Trace how the current overloads reach that method and determine the expected behavior for a CommandDefinition, Type[] types, and Func<object[], TReturn> mapper. Done means the cancellable unbounded mapping case is publicly available and covered by the repository's relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
database
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.