DapperLib / DapperLib/Dapper

Command not disposed with async using and ExecuteReaderAsync

Open
#2,185 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-triage
Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

Command not disposed in DbWrappedReader when using DisposeAsync.
=>
when using async using with ExecuteReaderAsync command is not disposed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at DbWrappedReader and trace the ExecuteReaderAsync path used with async using and DisposeAsync. Verify whether the underlying command is disposed after asynchronous reader disposal, then add or update coverage for that scenario and confirm the command is released.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.