DapperLib / DapperLib/Dapper

[Question]: Unused value in the QueryAsync<T>

Open
#2,184 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

In the SqlMapper.Async Line 451 and
Line 1323 what is the purpose of calling Nullable.GetUnderlyingType, if it is not used afterwards?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Dapper/SqlMapper.Async.cs at the referenced lines 451 and 1323, then trace the surrounding QueryAsync logic to see how Nullable.GetUnderlyingType is used. Establish whether the unused value is intentional or redundant; done means the purpose is documented in the issue or the scope of any cleanup is clearly identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
database
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.