DapperLib / DapperLib/Dapper

MultiMapAsync disposes reader in unbuffered query

Open
#2,099 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

  1. Create unbuffered CommandDefinition with flags CommandFlags.None.
  2. Call QueryAsync<TFirst, ..., TReturn>(command)

https://github.com/DapperLib/Dapper/blob/52160dc44699ec7eb5ad57d0dddc6ded4662fcb9/Dapper/SqlMapper.Async.cs#L940

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Dapper/SqlMapper.Async.cs around line 940 and reproduce the issue with an unbuffered CommandDefinition using CommandFlags.None and QueryAsync<TFirst, ..., TReturn>. Confirm the reader-disposal behavior and define done as preventing the reader from being disposed prematurely while preserving the unbuffered query behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.