DapperLib / DapperLib/Dapper

CustomPropertyTypeMap propertySelector does now allow null

Open
#2,011 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

The constructor of CustomPropertyTypeMap accepts two parameters. The propertySelector parameter is of type Func<Type, string, PropertyInfo>. If I understand correctly this means that the function must always return a PropertyInfo. Returning null is not allowed due to the project setting enable.
As the method public SqlMapper.IMemberMap? GetMember(string columnName) is the only method that uses the propertySelector and is already capable of handling a null return value, I would like to request to modify the constructor to (so changing the return type of the function from PropertyInfo to PropertyInfo?):

public CustomPropertyTypeMap(Type type, Func<Type, string, PropertyInfo?> propertySelector)

and of course the variable to:

private readonly Func<Type, string, PropertyInfo?> _propertySelector;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating CustomPropertyTypeMap, its constructor, and GetMember method. Compare the propertySelector and _propertySelector nullability annotations, then verify that nullable selectors are accepted while existing member mapping behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
database
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.