DapperLib / DapperLib/Dapper

ApplyNullValues behaviour with nullable types/nullable reference types

Open
#1,807 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

There have been a couple of issues around nullable reference types 1 2.

I was wondering what people think about the behavior of the ApplyNullValues setting in the context of nullable types (both nullable value types and reference types). I think it should throw an exception when a null value is read from the DB but the target is not nullable. In the case of nullable reference types this is definitely an issue because it would make fields that aren't supposed to be null null. For value types they would just be 0/default. Less bad, but still wrong in my opinion.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the ApplyNullValues behavior and the related issues 1393 and 1714. The issue does not name files, tests, or an agreed behavior; done would require a decided and tested policy for null database values assigned to nullable and non-nullable reference and value types.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design, databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.